summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@citi.umich.edu>2008-07-07 15:02:02 -0400
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-07-07 15:04:50 -0400
commit4f83aa302f8f8b42397c6d3703d670f0588c03ec (patch)
tree15ac10dc525eb365258f7fcd1faf0c7c5a9823e7
parent695e12f8d2917378d3b93059209e17415de96204 (diff)
downloadop-kernel-dev-4f83aa302f8f8b42397c6d3703d670f0588c03ec.zip
op-kernel-dev-4f83aa302f8f8b42397c6d3703d670f0588c03ec.tar.gz
nfsd: document open share bit tracking
It's not immediately obvious from the code why we're doing this. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Cc: Benny Halevy <bhalevy@panasas.com>
-rw-r--r--fs/nfsd/nfs4state.c18
1 files changed, 18 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index eca8aaa..c29b6ed 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1173,6 +1173,24 @@ static inline int deny_valid(u32 x)
return x <= NFS4_SHARE_DENY_BOTH;
}
+/*
+ * We store the NONE, READ, WRITE, and BOTH bits separately in the
+ * st_{access,deny}_bmap field of the stateid, in order to track not
+ * only what share bits are currently in force, but also what
+ * combinations of share bits previous opens have used. This allows us
+ * to enforce the recommendation of rfc 3530 14.2.19 that the server
+ * return an error if the client attempt to downgrade to a combination
+ * of share bits not explicable by closing some of its previous opens.
+ *
+ * XXX: This enforcement is actually incomplete, since we don't keep
+ * track of access/deny bit combinations; so, e.g., we allow:
+ *
+ * OPEN allow read, deny write
+ * OPEN allow both, deny none
+ * DOWNGRADE allow read, deny none
+ *
+ * which we should reject.
+ */
static void
set_access(unsigned int *access, unsigned long bmap) {
int i;
OpenPOWER on IntegriCloud