diff options
| author | Philip Langdale <philipl@overt.org> | 2007-01-04 07:04:47 -0800 |
|---|---|---|
| committer | Pierre Ossman <drzeus@drzeus.cx> | 2007-01-15 06:44:03 +0100 |
| commit | 6f949909e8f9e5d7e5584dc48d9a5e060c52aed1 (patch) | |
| tree | 0ffeb53000ea8f003fdbf5dc68d41da43777cbfe | |
| parent | 1b3b2631842ab60c1b7923bef102c610439ba3dd (diff) | |
| download | op-kernel-dev-6f949909e8f9e5d7e5584dc48d9a5e060c52aed1.zip op-kernel-dev-6f949909e8f9e5d7e5584dc48d9a5e060c52aed1.tar.gz | |
mmc: Correct definition of R6
During development of SDHC support, it was discovered that the definition
for R6 was incorrect. This patch fixes that and patches the drivers that
do switch on the response type.
Signed-off-by: Philip Langdale <philipl@overt.org>
Cc: Alex Dubov <oakad@yahoo.com>
Cc: Pavel Pisa <ppisa@pikron.com>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
| -rw-r--r-- | drivers/mmc/imxmmc.c | 3 | ||||
| -rw-r--r-- | drivers/mmc/omap.c | 5 | ||||
| -rw-r--r-- | drivers/mmc/pxamci.c | 2 | ||||
| -rw-r--r-- | drivers/mmc/tifm_sd.c | 3 | ||||
| -rw-r--r-- | include/linux/mmc/mmc.h | 2 |
5 files changed, 3 insertions, 12 deletions
diff --git a/drivers/mmc/imxmmc.c b/drivers/mmc/imxmmc.c index 06e7fcd..bfb9ff6 100644 --- a/drivers/mmc/imxmmc.c +++ b/drivers/mmc/imxmmc.c @@ -351,9 +351,6 @@ static void imxmci_start_cmd(struct imxmci_host *host, struct mmc_command *cmd, case MMC_RSP_R3: /* short */ cmdat |= CMD_DAT_CONT_RESPONSE_FORMAT_R3; break; - case MMC_RSP_R6: /* short CRC */ - cmdat |= CMD_DAT_CONT_RESPONSE_FORMAT_R6; - break; default: break; } diff --git a/drivers/mmc/omap.c b/drivers/mmc/omap.c index 1e5407d..d30540b 100644 --- a/drivers/mmc/omap.c +++ b/drivers/mmc/omap.c @@ -208,7 +208,7 @@ mmc_omap_start_command(struct mmc_omap_host *host, struct mmc_command *cmd) break; case MMC_RSP_R1: case MMC_RSP_R1B: - /* resp 1, resp 1b */ + /* resp 1, 1b, 6, 7 */ resptype = 1; break; case MMC_RSP_R2: @@ -217,9 +217,6 @@ mmc_omap_start_command(struct mmc_omap_host *host, struct mmc_command *cmd) case MMC_RSP_R3: resptype = 3; break; - case MMC_RSP_R6: - resptype = 6; - break; default: dev_err(mmc_dev(host->mmc), "Invalid response type: %04x\n", mmc_resp_type(cmd)); break; diff --git a/drivers/mmc/pxamci.c b/drivers/mmc/pxamci.c index 45a9283..6073d99 100644 --- a/drivers/mmc/pxamci.c +++ b/drivers/mmc/pxamci.c @@ -171,7 +171,7 @@ static void pxamci_start_cmd(struct pxamci_host *host, struct mmc_command *cmd, #define RSP_TYPE(x) ((x) & ~(MMC_RSP_BUSY|MMC_RSP_OPCODE)) switch (RSP_TYPE(mmc_resp_type(cmd))) { - case RSP_TYPE(MMC_RSP_R1): /* r1, r1b, r6 */ + case RSP_TYPE(MMC_RSP_R1): /* r1, r1b, r6, r7 */ cmdat |= CMDAT_RESP_SHORT; break; case RSP_TYPE(MMC_RSP_R3): diff --git a/drivers/mmc/tifm_sd.c b/drivers/mmc/tifm_sd.c index f18ad99..fa4a528 100644 --- a/drivers/mmc/tifm_sd.c +++ b/drivers/mmc/tifm_sd.c @@ -173,9 +173,6 @@ static unsigned int tifm_sd_op_flags(struct mmc_command *cmd) case MMC_RSP_R3: rc |= TIFM_MMCSD_RSP_R3; break; - case MMC_RSP_R6: - rc |= TIFM_MMCSD_RSP_R6; - break; default: BUG(); } diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h index a3594df..bcf2490 100644 --- a/include/linux/mmc/mmc.h +++ b/include/linux/mmc/mmc.h @@ -42,7 +42,7 @@ struct mmc_command { #define MMC_RSP_R1B (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE|MMC_RSP_BUSY) #define MMC_RSP_R2 (MMC_RSP_PRESENT|MMC_RSP_136|MMC_RSP_CRC) #define MMC_RSP_R3 (MMC_RSP_PRESENT) -#define MMC_RSP_R6 (MMC_RSP_PRESENT|MMC_RSP_CRC) +#define MMC_RSP_R6 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE) #define mmc_resp_type(cmd) ((cmd)->flags & (MMC_RSP_PRESENT|MMC_RSP_136|MMC_RSP_CRC|MMC_RSP_BUSY|MMC_RSP_OPCODE)) |
