summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2010-03-01 09:57:54 -0800
committerSage Weil <sage@newdream.net>2010-03-01 15:28:00 -0800
commit195d3ce2cc9a8ec69827f6369c41b269345b9988 (patch)
tree9ef91489d379ac612895b6ab3118535969aba152
parent6f863e712d4114e8ae2f02de64ebeac0546ebaa0 (diff)
downloadop-kernel-dev-195d3ce2cc9a8ec69827f6369c41b269345b9988.zip
op-kernel-dev-195d3ce2cc9a8ec69827f6369c41b269345b9988.tar.gz
ceph: return EBADF if waiting for caps on closed file
Verify the file is actually open for the given caps when we are waiting for caps. This ensures we will wake up and return EBADF if another thread closes the file out from under us. Note that EBADF is also the correct return code from write(2) when called on a file handle opened for reading (although the vfs should catch that). Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/caps.c9
-rw-r--r--fs/ceph/file.c3
2 files changed, 9 insertions, 3 deletions
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 9afa8d3..06f1979 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1923,14 +1923,17 @@ static int try_get_cap_refs(struct ceph_inode_info *ci, int need, int want,
struct inode *inode = &ci->vfs_inode;
int ret = 0;
int have, implemented;
+ int file_wanted;
dout("get_cap_refs %p need %s want %s\n", inode,
ceph_cap_string(need), ceph_cap_string(want));
spin_lock(&inode->i_lock);
- /* make sure we _have_ some caps! */
- if (!__ceph_is_any_caps(ci)) {
- dout("get_cap_refs %p no real caps\n", inode);
+ /* make sure file is actually open */
+ file_wanted = __ceph_caps_file_wanted(ci);
+ if ((file_wanted & need) == 0) {
+ dout("try_get_cap_refs need %s file_wanted %s, EBADF\n",
+ ceph_cap_string(need), ceph_cap_string(file_wanted));
*err = -EBADF;
ret = 1;
goto out;
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 88932c9..5d2af84 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -262,6 +262,9 @@ int ceph_release(struct inode *inode, struct file *file)
kfree(cf->dir_info);
dput(cf->dentry);
kmem_cache_free(ceph_file_cachep, cf);
+
+ /* wake up anyone waiting for caps on this inode */
+ wake_up(&ci->i_cap_wq);
return 0;
}
OpenPOWER on IntegriCloud