summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2006-11-23 11:48:28 -0800
committerDavid S. Miller <davem@sunset.davemloft.net>2006-11-25 15:16:50 -0800
commit95f6134e175fd69ab3f088f7a09adbd3fd3548e1 (patch)
tree0fdd4d94c7a2256efe12e8bf5109cbad5141e1ea
parentac16ca6412d9feb5b2f8fc76a4ed938b5d107f94 (diff)
downloadop-kernel-dev-95f6134e175fd69ab3f088f7a09adbd3fd3548e1.zip
op-kernel-dev-95f6134e175fd69ab3f088f7a09adbd3fd3548e1.tar.gz
[6PACK]: Masking bug in 6pack driver.
Looks like a broken masking to me, binary not is used where bitwise not was intended. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/hamradio/6pack.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 86b3bb9..92420f0 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -914,7 +914,7 @@ static void decode_prio_command(struct sixpack *sp, unsigned char cmd)
printk(KERN_DEBUG "6pack: protocol violation\n");
else
sp->status = 0;
- cmd &= !SIXP_RX_DCD_MASK;
+ cmd &= ~SIXP_RX_DCD_MASK;
}
sp->status = cmd & SIXP_PRIO_DATA_MASK;
} else { /* output watchdog char if idle */
OpenPOWER on IntegriCloud