summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-01-05 13:59:06 +0000
committerSamuel Ortiz <sameo@linux.intel.com>2010-01-18 12:30:26 +0100
commit6f2af72a2451b7491fba820b1d1b0b91c6a84027 (patch)
tree2b893aa89ce05e77f9da854bbfdba787f6456a15
parent9dffe2a32b0deef52605d50527c0d240b15cabf7 (diff)
downloadop-kernel-dev-6f2af72a2451b7491fba820b1d1b0b91c6a84027.zip
op-kernel-dev-6f2af72a2451b7491fba820b1d1b0b91c6a84027.tar.gz
mfd: WM8350 off by one bug
If irq == WM8350_NUM_IRQ that would put us past the end of the array. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r--drivers/mfd/wm8350-irq.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
index c8df547..9025f29 100644
--- a/drivers/mfd/wm8350-irq.c
+++ b/drivers/mfd/wm8350-irq.c
@@ -434,7 +434,7 @@ int wm8350_register_irq(struct wm8350 *wm8350, int irq,
irq_handler_t handler, unsigned long flags,
const char *name, void *data)
{
- if (irq < 0 || irq > WM8350_NUM_IRQ || !handler)
+ if (irq < 0 || irq >= WM8350_NUM_IRQ || !handler)
return -EINVAL;
if (wm8350->irq[irq].handler)
@@ -453,7 +453,7 @@ EXPORT_SYMBOL_GPL(wm8350_register_irq);
int wm8350_free_irq(struct wm8350 *wm8350, int irq)
{
- if (irq < 0 || irq > WM8350_NUM_IRQ)
+ if (irq < 0 || irq >= WM8350_NUM_IRQ)
return -EINVAL;
wm8350_mask_irq(wm8350, irq);
OpenPOWER on IntegriCloud