summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-07-23 14:01:29 -0700
committerDavid S. Miller <davem@davemloft.net>2008-07-23 14:01:29 -0700
commit5b3ab1dbd401b36ba2f9bfee2d2dae252fd62cd8 (patch)
treee03459ee944e51a49f46e71aa688c8507005659f
parent8a6d2ea0cd121e3bfff4dbce5bc111874cf9e9d2 (diff)
downloadop-kernel-dev-5b3ab1dbd401b36ba2f9bfee2d2dae252fd62cd8.zip
op-kernel-dev-5b3ab1dbd401b36ba2f9bfee2d2dae252fd62cd8.tar.gz
netdev: Remove warning from __netif_schedule().
It isn't helping anything and we aren't going to be able to change all the drivers that do queue wakeups in strange situations. Just letting a noop_qdisc get scheduled will work because when qdisc_run() executes via net_tx_work() it will simply find no packets pending when it makes the ->dequeue() call in qdisc_restart. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/dev.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 6bf217d..ccf97f9 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1341,9 +1341,6 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
void __netif_schedule(struct Qdisc *q)
{
- if (WARN_ON_ONCE(q == &noop_qdisc))
- return;
-
if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {
struct softnet_data *sd;
unsigned long flags;
OpenPOWER on IntegriCloud