summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOndrej Zary <linux@rainbow-software.org>2010-07-29 22:32:20 +0200
committerRussell King <rmk+kernel@arm.linux.org.uk>2010-07-30 23:29:33 +0100
commit00b4703f03ce04bd7f2f912fd05a243096ab826f (patch)
treede937808326366a5552ee92a3417f08380aa7776
parentf2d2420bbf4bb125ea5f2e1573d4da6b668fc78a (diff)
downloadop-kernel-dev-00b4703f03ce04bd7f2f912fd05a243096ab826f.zip
op-kernel-dev-00b4703f03ce04bd7f2f912fd05a243096ab826f.tar.gz
cyber2000fb: fix machine hang on module load
I was testing two CyberPro 2000 based PCI cards on x86 and the machine always hanged completely when the cyber2000fb module was loaded. It seems that the card hangs when some registers are accessed too quickly after writing RAMDAC control register. With this patch, both card work. Add delay after RAMDAC control register write to prevent hangs on module load. Signed-off-by: Ondrej Zary <linux@rainbow-software.org> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r--drivers/video/cyber2000fb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/cyber2000fb.c b/drivers/video/cyber2000fb.c
index 3a561df2..3eee829 100644
--- a/drivers/video/cyber2000fb.c
+++ b/drivers/video/cyber2000fb.c
@@ -436,6 +436,8 @@ static void cyber2000fb_write_ramdac_ctrl(struct cfb_info *cfb)
cyber2000fb_writeb(i | 4, 0x3cf, cfb);
cyber2000fb_writeb(val, 0x3c6, cfb);
cyber2000fb_writeb(i, 0x3cf, cfb);
+ /* prevent card lock-up observed on x86 with CyberPro 2000 */
+ cyber2000fb_readb(0x3cf, cfb);
}
static void cyber2000fb_set_timing(struct cfb_info *cfb, struct par_info *hw)
OpenPOWER on IntegriCloud