summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederik Deweerdt <deweerdt@free.fr>2006-10-03 01:16:11 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-03 08:04:20 -0700
commit42d3fb5a8771b840e0bd6dbcd0c734883dd90b6f (patch)
treea045f8baa20ff61e106d8cf09564eb9fc5638b4f
parentc8c94b11399b1dc7f08f7b28ec4289a727f0daee (diff)
downloadop-kernel-dev-42d3fb5a8771b840e0bd6dbcd0c734883dd90b6f.zip
op-kernel-dev-42d3fb5a8771b840e0bd6dbcd0c734883dd90b6f.tar.gz
[PATCH] arm build fail: vfpsingle.c
It looks like Zach Brown's patch pr_debug-check-pr_debug-arguments worked as inteded. That is, it doesn't "allow completely incorrect code to build." :). The arm build fails with the following message: CC arch/arm/vfp/vfpsingle.o arch/arm/vfp/vfpsingle.c: In function `__vfp_single_normaliseround': arch/arm/vfp/vfpsingle.c:201: error: `func' undeclared (first use in this function) arch/arm/vfp/vfpsingle.c:201: error: (Each undeclared identifier is reported only once arch/arm/vfp/vfpsingle.c:201: error: for each function it appears in.) make[1]: *** [arch/arm/vfp/vfpsingle.o] Error 1 make: *** [arch/arm/vfp] Error 2 The following patch fixes the issue by using func only when DEBUG is defined. Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Zach Brown <zach.brown@oracle.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--arch/arm/vfp/vfpsingle.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/arm/vfp/vfpsingle.c b/arch/arm/vfp/vfpsingle.c
index ab5e950..0221ba3 100644
--- a/arch/arm/vfp/vfpsingle.c
+++ b/arch/arm/vfp/vfpsingle.c
@@ -198,8 +198,10 @@ u32 vfp_single_normaliseround(int sd, struct vfp_single *vs, u32 fpscr, u32 exce
vfp_single_dump("pack: final", vs);
{
s32 d = vfp_single_pack(vs);
+#ifdef DEBUG
pr_debug("VFP: %s: d(s%d)=%08x exceptions=%08x\n", func,
sd, d, exceptions);
+#endif
vfp_put_float(d, sd);
}
OpenPOWER on IntegriCloud