summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-08-09 11:42:32 +0200
committerRalf Baechle <ralf@linux-mips.org>2009-12-02 23:58:32 +0000
commit0fdd07f77fd9cc6a7d49076793daef06ea5d8f13 (patch)
tree368db433db7c1927a3eddb8b746b4038172053c0
parentdbf763a2f1c117cfe45bbbd2c874a150f0e0900b (diff)
downloadop-kernel-dev-0fdd07f77fd9cc6a7d49076793daef06ea5d8f13.zip
op-kernel-dev-0fdd07f77fd9cc6a7d49076793daef06ea5d8f13.tar.gz
VIDEO: Correct use of request_region/request_mem_region
request_region should be used with release_region, not request_mem_region. Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c, the problem is actually the other way around; request_mem_region should be used instead of request_region. The semantic patch that finds/fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ expression start; @@ request_region(start,...) @b1@ expression r1.start; @@ request_mem_region(start,...) @depends on !b1@ expression r1.start; expression E; @@ - release_mem_region + release_region (start,E) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r--drivers/video/gbefb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/gbefb.c b/drivers/video/gbefb.c
index 1a83709..f67db42 100644
--- a/drivers/video/gbefb.c
+++ b/drivers/video/gbefb.c
@@ -1147,7 +1147,7 @@ static int __init gbefb_probe(struct platform_device *p_dev)
gbefb_setup(options);
#endif
- if (!request_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
+ if (!request_mem_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
printk(KERN_ERR "gbefb: couldn't reserve mmio region\n");
ret = -EBUSY;
goto out_release_framebuffer;
OpenPOWER on IntegriCloud