diff options
| author | Jesper Juhl <jesper.juhl@gmail.com> | 2007-10-16 01:27:52 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 09:43:10 -0700 |
| commit | e8a285b7b10029c3da7e9bbaa1659e7e08178912 (patch) | |
| tree | a97878e17221c2686e91dd8cfea2b03dbde7d855 | |
| parent | b1b2e7cf4a9742f61d76fcb419b1fd13159876a5 (diff) | |
| download | op-kernel-dev-e8a285b7b10029c3da7e9bbaa1659e7e08178912.zip op-kernel-dev-e8a285b7b10029c3da7e9bbaa1659e7e08178912.tar.gz | |
isdn: guard against a potential NULL pointer dereference in old_capi_manufacturer()
In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call to
get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then we'll be
dereferencing a NULL pointer in the very next line.
(Found by Coverity checker as bug #402)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/isdn/capi/kcapi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c index 9f73bc27..f555318 100644 --- a/drivers/isdn/capi/kcapi.c +++ b/drivers/isdn/capi/kcapi.c @@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void __user *data) return -EFAULT; } card = get_capi_ctr_by_nr(ldef.contr); + if (!card) + return -EINVAL; card = capi_ctr_get(card); if (!card) return -ESRCH; |
