summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Graf <tgraf@suug.ch>2006-11-10 14:11:04 -0800
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-02 21:22:12 -0800
commitf465e489c457821751f6253abaaf28c10f9d8895 (patch)
treed36ceef24267d7b5fe4d836435a5760dc64f67be
parent339bf98ffc6a8d8eb16fc532ac57ffbced2f8a68 (diff)
downloadop-kernel-dev-f465e489c457821751f6253abaaf28c10f9d8895.zip
op-kernel-dev-f465e489c457821751f6253abaaf28c10f9d8895.tar.gz
[IPv6] rules: Remove bogus tos validation check
Noticed by Al Viro: (frh->tos & ~IPV6_FLOWINFO_MASK)) where IPV6_FLOWINFO_MASK is htonl(0xfffffff) and frh->tos is u8, which makes no sense here... Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/fib6_rules.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
index d587dde..0862809 100644
--- a/net/ipv6/fib6_rules.c
+++ b/net/ipv6/fib6_rules.c
@@ -142,8 +142,7 @@ static int fib6_rule_configure(struct fib_rule *rule, struct sk_buff *skb,
int err = -EINVAL;
struct fib6_rule *rule6 = (struct fib6_rule *) rule;
- if (frh->src_len > 128 || frh->dst_len > 128 ||
- (frh->tos & ~IPV6_FLOWINFO_MASK))
+ if (frh->src_len > 128 || frh->dst_len > 128)
goto errout;
if (rule->action == FR_ACT_TO_TBL) {
OpenPOWER on IntegriCloud