summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Kleikamp <shaggy@linux.vnet.ibm.com>2007-05-05 14:24:05 -0500
committerDave Kleikamp <shaggy@linux.vnet.ibm.com>2007-05-05 14:24:05 -0500
commit05ec9e26be1f668ccba4ca54d9a4966c6208c611 (patch)
treef05d3437dd0f0623b139e109fe8a53e5ea336696
parent3cbb1c8e1a4787d3dc2951b7615d7bb3788c49a0 (diff)
downloadop-kernel-dev-05ec9e26be1f668ccba4ca54d9a4966c6208c611.zip
op-kernel-dev-05ec9e26be1f668ccba4ca54d9a4966c6208c611.tar.gz
JFS: Fix race waking up jfsIO kernel thread
It's possible for a journal I/O request to be added to the log_redrive queue and the jfsIO thread to be awakened after the thread releases log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE. The jfsIO thread should set the state before giving up the spinlock, so the waking thread will really wake it. Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
-rw-r--r--fs/jfs/jfs_logmgr.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index ff7f1be..16c6268 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg)
lbmStartIO(bp);
spin_lock_irq(&log_redrive_lock);
}
- spin_unlock_irq(&log_redrive_lock);
if (freezing(current)) {
+ spin_unlock_irq(&log_redrive_lock);
refrigerator();
} else {
set_current_state(TASK_INTERRUPTIBLE);
+ spin_unlock_irq(&log_redrive_lock);
schedule();
__set_current_state(TASK_RUNNING);
}
OpenPOWER on IntegriCloud