summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Neukum <oneukum@suse.de>2007-05-02 10:33:10 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2007-05-22 23:45:48 -0700
commit5ac43d1fbbfd1b89f83c1a907c58d558d262e441 (patch)
treea3b713dce58dce77787d0aa404a41d57d4f70a87
parentad9ddd66c6e8a79630a975ff0bb8d45a11abe630 (diff)
downloadop-kernel-dev-5ac43d1fbbfd1b89f83c1a907c58d558d262e441.zip
op-kernel-dev-5ac43d1fbbfd1b89f83c1a907c58d558d262e441.tar.gz
USB: fix omninet memory leak found by coverity
the transfer of allocating the descriptor in attach and no longer in open was incomplete resulting in a memory leak coverity spotted. This fix is against the patch set you posted. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/serial/omninet.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 4adfab9..00afc17 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -165,12 +165,10 @@ static int omninet_open (struct usb_serial_port *port, struct file *filp)
{
struct usb_serial *serial = port->serial;
struct usb_serial_port *wport;
- struct omninet_data *od = usb_get_serial_port_data(port);
int result = 0;
dbg("%s - port %d", __FUNCTION__, port->number);
- od = kmalloc( sizeof(struct omninet_data), GFP_KERNEL );
wport = serial->port[1];
wport->tty = port->tty;
OpenPOWER on IntegriCloud