diff options
| author | Russell King <rmk+lkml@arm.linux.org.uk> | 2005-04-16 15:26:39 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-04-16 15:26:39 -0700 |
| commit | 23907eb8c22e39bcf3d7e7a35a2db1e416157adb (patch) | |
| tree | 5701cae61a346eb758b676ec19e641892ce61bec | |
| parent | c907132d534c10b4f34a60383c8384403cb424a4 (diff) | |
| download | op-kernel-dev-23907eb8c22e39bcf3d7e7a35a2db1e416157adb.zip op-kernel-dev-23907eb8c22e39bcf3d7e7a35a2db1e416157adb.tar.gz | |
[PATCH] serial: fix comments in 8250.c
Fix the formatting of some comments in 8250.c, and add a note that the
register_serial / unregister_serial shouldn't be used in new code.
We do this here in preference to adding to linux/serial.h, since that is used
by a number of non-8250 drivers which pretend to be 8250. It is not known
whether it would be appropriate to do so.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | drivers/serial/8250.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 201c3b9..218b693 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1065,8 +1065,10 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs) tty_flip_buffer_push(tty); spin_lock(&up->port.lock); } - /* If this failed then we will throw away the - bytes but must do so to clear interrupts */ + /* + * If this failed then we will throw away the + * bytes but must do so to clear interrupts + */ } ch = serial_inp(up, UART_RX); flag = TTY_NORMAL; @@ -1106,7 +1108,7 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs) up->port.icount.overrun++; /* - * Mask off conditions which should be ingored. + * Mask off conditions which should be ignored. */ lsr &= up->port.read_status_mask; @@ -2570,6 +2572,9 @@ MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR); * If this fails an error is returned. * * On success the port is ready to use and the line number is returned. + * + * Note: this function is deprecated - use serial8250_register_port + * instead. */ int register_serial(struct serial_struct *req) { @@ -2624,6 +2629,9 @@ EXPORT_SYMBOL(register_serial); * * Remove one serial port. This may not be called from interrupt * context. We hand the port back to our local PM control. + * + * Note: this function is deprecated - use serial8250_unregister_port + * instead. */ void unregister_serial(int line) { |
