summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrey Savochkin <saw@swsoft.com>2006-07-03 19:50:14 -0700
committerDavid S. Miller <davem@davemloft.net>2006-07-03 19:50:14 -0700
commit69ee20a58fa0cad6520c2a9538100a87ef0abd7d (patch)
tree3045353c484b04b1ff38a6650085415a9a9b046b
parent3c6b377321678c649f9b3c66da0149975c614102 (diff)
downloadop-kernel-dev-69ee20a58fa0cad6520c2a9538100a87ef0abd7d.zip
op-kernel-dev-69ee20a58fa0cad6520c2a9538100a87ef0abd7d.tar.gz
[BRIDGE]: br_dump_ifinfo index fix
Fix for inability of br_dump_ifinfo to handle non-zero start index: loop index never increases when entered with non-zero start. Spotted by Kirill Korotaev. Signed-off-by: Andrey Savochkin <saw@swsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/bridge/br_netlink.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 881d7d1..06abb66 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -117,12 +117,13 @@ static int br_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
continue;
if (idx < s_idx)
- continue;
+ goto cont;
err = br_fill_ifinfo(skb, p, NETLINK_CB(cb->skb).pid,
cb->nlh->nlmsg_seq, RTM_NEWLINK, NLM_F_MULTI);
if (err <= 0)
break;
+cont:
++idx;
}
read_unlock(&dev_base_lock);
OpenPOWER on IntegriCloud