summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Chinner <dgc@sgi.com>2007-11-23 16:30:23 +1100
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>2007-12-10 13:46:59 +1100
commita7430847fcb19297d6db833f35b9c9645c4a6395 (patch)
treeda7b2712a0ae98f40f3e937ff9cdc428005a4fda
parent77be55a5a13d9c7ddf780a93861f2fba33f8be1a (diff)
downloadop-kernel-dev-a7430847fcb19297d6db833f35b9c9645c4a6395.zip
op-kernel-dev-a7430847fcb19297d6db833f35b9c9645c4a6395.tar.gz
[XFS] Fix broken inode cluster setup.
The radix tree based inode caches did away with the inode cluster hashes, replacing them with a bunch of masking and gang lookups on the radix tree. This masking got broken when moving the code to per-ag radix trees and indexing by agino # rather than straight inode number. The result is clustered inode writeback does not cluster and things can go extremely slowly when there are lots of inodes to write. Fix it up by comparing the agino # of the inode we just looked up to the index of the cluster we are looking for. Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com> SGI-PV: 972915 SGI-Modid: xfs-linux-melb:xfs-kern:30033a Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
-rw-r--r--fs/xfs/xfs_iget.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index 488836e..fb69ef1 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -267,7 +267,7 @@ finish_inode:
icl = NULL;
if (radix_tree_gang_lookup(&pag->pag_ici_root, (void**)&iq,
first_index, 1)) {
- if ((iq->i_ino & mask) == first_index)
+ if ((XFS_INO_TO_AGINO(mp, iq->i_ino) & mask) == first_index)
icl = iq->i_cluster;
}
OpenPOWER on IntegriCloud