summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@osdl.org>2006-03-07 11:06:35 -0800
committerFrancois Romieu <romieu@fr.zoreil.com>2006-03-09 23:19:01 +0100
commit28a31860191c0d5710d42f85510daac0a3c26a01 (patch)
treeb20aa66646cefeff18d559745018f2f459bdd2ab
parent39bf4295bb4bcb0c108f74b72dd2eb5b9b9dfacc (diff)
downloadop-kernel-dev-28a31860191c0d5710d42f85510daac0a3c26a01.zip
op-kernel-dev-28a31860191c0d5710d42f85510daac0a3c26a01.tar.gz
sky2: not random enough
Don't use sky2 to seed random pool beacause the network packet arrival time will not be truly random due to NAPI and interrupt mitigation. Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
-rw-r--r--drivers/net/sky2.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 72c1630..dc4feaf 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3243,8 +3243,7 @@ static int __devinit sky2_probe(struct pci_dev *pdev,
}
}
- err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ | SA_SAMPLE_RANDOM,
- DRV_NAME, hw);
+ err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw);
if (err) {
printk(KERN_ERR PFX "%s: cannot assign irq %d\n",
pci_name(pdev), pdev->irq);
OpenPOWER on IntegriCloud