diff options
author | Randall Nortman <linuxkernellist@wonderclown.com> | 2005-10-14 17:21:50 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-10-14 18:13:31 -0700 |
commit | 7a3ca7d2b5ec31b2cfa594b961d77e68075e33c7 (patch) | |
tree | 29ba927b48b3c69517954dcbf45098455d4ea6e4 | |
parent | f8cc5756dee3c2a4c56a7f089291f5ae0232747f (diff) | |
download | op-kernel-dev-7a3ca7d2b5ec31b2cfa594b961d77e68075e33c7.zip op-kernel-dev-7a3ca7d2b5ec31b2cfa594b961d77e68075e33c7.tar.gz |
[PATCH] usbserial: Regression in USB generic serial driver
Kernel version 2.6.13 introduced a regression in the generic USB
serial converter driver (usbserial.o, drivers/usb/serial/generic.c).
The bug manifests, as far as I can tell, whenever you attempt to write
to the device -- the write will never complete (write() returns 0, or
blocks).
Signed-off-by: Randall Nortman <oss@wonderclown.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/usb/serial/generic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index ddde5fb..5f7d319 100644 --- a/drivers/usb/serial/generic.c +++ b/drivers/usb/serial/generic.c @@ -223,7 +223,7 @@ int usb_serial_generic_write_room (struct usb_serial_port *port) dbg("%s - port %d", __FUNCTION__, port->number); if (serial->num_bulk_out) { - if (port->write_urb_busy) + if (!(port->write_urb_busy)) room = port->bulk_out_size; } |