summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:47:31 +0100
committerLee Jones <lee.jones@linaro.org>2016-01-14 08:43:37 +0000
commitfe0b486729e1ae837cf0afd1005d3c10a78f9807 (patch)
tree70091379199a74ae82ef22e953e883713761c0f9
parentf7d623669648d2a8d7e81671294c26e480ddcc79 (diff)
downloadop-kernel-dev-fe0b486729e1ae837cf0afd1005d3c10a78f9807.zip
op-kernel-dev-fe0b486729e1ae837cf0afd1005d3c10a78f9807.tar.gz
mfd: dm355evm_mps: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r--drivers/mfd/dm355evm_msp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index 4c826f7..bf3e0b2 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
return status;
if (reg == DM355EVM_MSP_LED)
msp_led_cache = status;
- return status & MSP_GPIO_MASK(offset);
+ return !!(status & MSP_GPIO_MASK(offset));
}
static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
OpenPOWER on IntegriCloud