summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSomya Anand <somyaanand214@gmail.com>2015-03-16 19:34:10 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-16 16:14:35 +0100
commitdc6ed26dc32f2365647e9a156beafe3dcbde612e (patch)
tree4945d1c085225ecc14fc580e8531436864654d7c
parent212db303ed21df1bee5037362f3a1098b53b5e55 (diff)
downloadop-kernel-dev-dc6ed26dc32f2365647e9a156beafe3dcbde612e.zip
op-kernel-dev-dc6ed26dc32f2365647e9a156beafe3dcbde612e.tar.gz
Staging: iio: use !x instead of x == NULL
Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL represents failure, !x is commonly used. This patch cleans up the tests on the results of these functions, thereby using !x instead of x == NULL or NULL == x. This is done via following coccinelle script: @prob_7@ identifier x; statement S; @@ ( x = devm_kzalloc(...); | x = usb_alloc_urb(...); | x = kmalloc_array(...); | x = devm_ioremap(...); | x = alloc_netdev(...); ) ... - if(NULL == x) + if(!x) S Further we have used isomorphism characteristics of coccinelle to indicate x == NULL and NULL == x are equivalent. This is done via following iso script. Expression @ is_null @ expression X; @@ X == NULL <=> NULL == X Signed-off-by: Somya Anand <somyaanand214@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/iio/trigger/iio-trig-bfin-timer.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
index 2af8d67..3c1c8c6 100644
--- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
+++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
@@ -183,7 +183,7 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev)
int ret;
st = devm_kzalloc(&pdev->dev, sizeof(*st), GFP_KERNEL);
- if (st == NULL)
+ if (!st)
return -ENOMEM;
st->irq = platform_get_irq(pdev, 0);
OpenPOWER on IntegriCloud