summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Kershner <david.kershner@unisys.com>2016-11-21 12:15:46 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-23 10:01:57 +0100
commit2d26aeb77357678e38c931c760d57bda084112ea (patch)
treef36afd7dc63527593d1816a12179f882b8b0893f
parent79c3f971d9ba718db6533c85b6d09edc6e47cd69 (diff)
downloadop-kernel-dev-2d26aeb77357678e38c931c760d57bda084112ea.zip
op-kernel-dev-2d26aeb77357678e38c931c760d57bda084112ea.tar.gz
staging: unisys: visorbus: controlvm_respond add error handling
The function visorchanel_signalinsert now returns an error, propagate the error up the stack to be handled. Signed-off-by: David Kershner <david.kershner@unisys.com> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/unisys/visorbus/visorchipset.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 331f6b1..0c454f6 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -548,19 +548,17 @@ out_respond:
return res;
}
-static void
+static int
controlvm_respond(struct controlvm_message_header *msg_hdr, int response)
{
struct controlvm_message outmsg;
controlvm_init_response(&outmsg, msg_hdr, response);
if (outmsg.hdr.flags.test_message == 1)
- return;
+ return -EINVAL;
- if (visorchannel_signalinsert(controlvm_channel,
- CONTROLVM_QUEUE_REQUEST, &outmsg)) {
- return;
- }
+ return visorchannel_signalinsert(controlvm_channel,
+ CONTROLVM_QUEUE_REQUEST, &outmsg);
}
static void controlvm_respond_physdev_changestate(
OpenPOWER on IntegriCloud