summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2013-01-23 18:25:01 -0500
committerJ. Bruce Fields <bfields@redhat.com>2013-01-23 18:25:01 -0500
commitff89be87c70247ffe3a72271e02eb7765cdd12c4 (patch)
treed089d9e8fb4eae00fcbb41a4e6727267063a754c
parentbca0ec6511bb96bcb6cb247fd4100a4ea1d1e4f5 (diff)
downloadop-kernel-dev-ff89be87c70247ffe3a72271e02eb7765cdd12c4.zip
op-kernel-dev-ff89be87c70247ffe3a72271e02eb7765cdd12c4.tar.gz
nfsd4: require version 4 when enabling or disabling minorversion
The current code will allow silly things like: echo "+2 +3 +4 +7.1">/proc/fs/nfsd/versions Reported-by: Fan Chaoting <fanchaoting@cn.fujitsu.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfsctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 7493428..65889ec 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -534,7 +534,7 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
else
num = simple_strtol(vers, &minorp, 0);
if (*minorp == '.') {
- if (num < 4)
+ if (num != 4)
return -EINVAL;
minor = simple_strtoul(minorp+1, NULL, 0);
if (minor == 0)
OpenPOWER on IntegriCloud