summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2007-04-23 22:36:13 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-25 22:29:47 -0700
commitf9d106a6d53b57b78eae5544f9582c643343a764 (patch)
treed1e23afbd2128669b07dfdd7cbd27870d0512cb0
parent7752237e9f07b316f81aebdc43f0d7c9a4ba0acf (diff)
downloadop-kernel-dev-f9d106a6d53b57b78eae5544f9582c643343a764.zip
op-kernel-dev-f9d106a6d53b57b78eae5544f9582c643343a764.tar.gz
[NET]: Warn about GSO/checksum abuse
Now that Patrick has added the code to deal with GSO in netfilter, we no longer need the crutch that computes partial checksums just before transmission. This patch turns this into a warning again. If this goes OK, we can then turn it into a BUG_ON and remove the gso_send_check cruft. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 18c51b4..d82d00f 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1202,7 +1202,7 @@ struct sk_buff *skb_gso_segment(struct sk_buff *skb, int features)
skb->mac_len = skb->network_header - skb->mac_header;
__skb_pull(skb, skb->mac_len);
- if (unlikely(skb->ip_summed != CHECKSUM_PARTIAL)) {
+ if (WARN_ON(skb->ip_summed != CHECKSUM_PARTIAL)) {
if (skb_header_cloned(skb) &&
(err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC)))
return ERR_PTR(err);
OpenPOWER on IntegriCloud