summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorxiaojin <jin.xiao@intel.com>2012-12-19 11:53:43 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-15 21:54:41 -0800
commitf96f7f7f39af53274d98aa9c29d6fa4d122218a4 (patch)
tree072676b629e4ac854d41562e09c5667d3edf1c1c
parent5425e03f97d1e5847372aae0b895d8d1c9bf2741 (diff)
downloadop-kernel-dev-f96f7f7f39af53274d98aa9c29d6fa4d122218a4.zip
op-kernel-dev-f96f7f7f39af53274d98aa9c29d6fa4d122218a4.tar.gz
n_gsm.c: add tx_lock in gsm_send
All the call to gsm->output should be in the tx_lock, that could avoid potential race from MUX level. But we have no tx_lock in gsm_send. This patch is to add tx_lock in gsm_send. Signed-off-by: xiaojin <jin.xiao@intel.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/n_gsm.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index dcc0430..4572117 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -573,6 +573,7 @@ static void gsm_send(struct gsm_mux *gsm, int addr, int cr, int control)
int len;
u8 cbuf[10];
u8 ibuf[3];
+ unsigned long flags;
switch (gsm->encoding) {
case 0:
@@ -602,7 +603,9 @@ static void gsm_send(struct gsm_mux *gsm, int addr, int cr, int control)
WARN_ON(1);
return;
}
+ spin_lock_irqsave(&gsm->tx_lock, flags);
gsm->output(gsm, cbuf, len);
+ spin_unlock_irqrestore(&gsm->tx_lock, flags);
gsm_print_packet("-->", addr, cr, control, NULL, 0);
}
OpenPOWER on IntegriCloud