summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:47:05 +0100
committerLee Jones <lee.jones@linaro.org>2016-01-14 08:43:43 +0000
commitf8e3a514bf98a94255bd1534a21aebaf795b7a13 (patch)
treeaf1591ecd927cfc1e6808029dc358a43f383c225
parentfe0b486729e1ae837cf0afd1005d3c10a78f9807 (diff)
downloadop-kernel-dev-f8e3a514bf98a94255bd1534a21aebaf795b7a13.zip
op-kernel-dev-f8e3a514bf98a94255bd1534a21aebaf795b7a13.tar.gz
mfd: asic3: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Paul Parsons <lost.distance@yahoo.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r--drivers/mfd/asic3.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a726f01..73812ee 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
return -EINVAL;
}
- return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
+ return !!(asic3_read_register(asic,
+ gpio_base + ASIC3_GPIO_STATUS) & mask);
}
static void asic3_gpio_set(struct gpio_chip *chip,
OpenPOWER on IntegriCloud