summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorian Fainelli <f.fainelli@gmail.com>2016-07-15 16:41:16 -0700
committerDavid S. Miller <davem@davemloft.net>2016-07-16 22:06:00 -0700
commitea6ff112b095dce2060c304195904d859c3e2625 (patch)
tree85f63a6948c2cea5bdea6e4ac69dc0df05758bb4
parentde702da7a823ab0c4a1e53ed79a2695f0d453855 (diff)
downloadop-kernel-dev-ea6ff112b095dce2060c304195904d859c3e2625.zip
op-kernel-dev-ea6ff112b095dce2060c304195904d859c3e2625.tar.gz
net: nb8800: Fix SKB leak in nb8800_receive()
In case nb8800_receive() fails to allocate a fragment, we would leak the SKB freshly allocated and just return, instead, free it. Reported-by: coverity (CID 1341750) Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Mans Rullgard <mans@mansr.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/aurora/nb8800.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 08a23e6..1a3555d 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -259,6 +259,7 @@ static void nb8800_receive(struct net_device *dev, unsigned int i,
if (err) {
netdev_err(dev, "rx buffer allocation failed\n");
dev->stats.rx_dropped++;
+ dev_kfree_skb(skb);
return;
}
OpenPOWER on IntegriCloud