summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2013-11-15 15:50:31 +0800
committerMark Brown <broonie@linaro.org>2013-11-18 11:29:30 +0000
commite322ce9365693b417867f6bd700ddf09cca36b37 (patch)
tree3d9b71c899853b1f5f052da2070c6e3abe82559e
parent82f85cf98f0eb60093e8b3d606711c2d49538478 (diff)
downloadop-kernel-dev-e322ce9365693b417867f6bd700ddf09cca36b37.zip
op-kernel-dev-e322ce9365693b417867f6bd700ddf09cca36b37.tar.gz
spi: spi-mxs: fix reference leak to master in mxs_spi_remove()
Once a spi_master_get() call succeeds, we need an additional spi_master_put() call to free the memory, otherwise we will leak a reference to master. Fix by removing the unnecessary spi_master_get() call. Fixes: 33e195acf268 ('spi: mxs: use devm_spi_register_master()') Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--drivers/spi/spi-mxs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index de33305..37b3e41 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -565,7 +565,7 @@ static int mxs_spi_remove(struct platform_device *pdev)
struct mxs_spi *spi;
struct mxs_ssp *ssp;
- master = spi_master_get(platform_get_drvdata(pdev));
+ master = platform_get_drvdata(pdev);
spi = spi_master_get_devdata(master);
ssp = &spi->ssp;
OpenPOWER on IntegriCloud