summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2010-08-26 09:26:37 -0700
committerSage Weil <sage@newdream.net>2010-08-26 09:26:37 -0700
commite072f8aa3587710cd35cce0f6b6efd7b4276c327 (patch)
treea0455b3ed1d76880a6553d39f017081a1832f5ba
parentf44c3890d9fd6e4284518ff3bb16879fee194a3a (diff)
downloadop-kernel-dev-e072f8aa3587710cd35cce0f6b6efd7b4276c327.zip
op-kernel-dev-e072f8aa3587710cd35cce0f6b6efd7b4276c327.tar.gz
ceph: don't BUG on ENOMEM during mds reconnect
We are in a position to return an error; do that instead. Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/mds_client.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 8d1f11c..f091b13 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -2324,7 +2324,7 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap,
path = ceph_mdsc_build_path(dentry, &pathlen, &pathbase, 0);
if (IS_ERR(path)) {
err = PTR_ERR(path);
- BUG_ON(err);
+ goto out_dput;
}
} else {
path = NULL;
@@ -2332,7 +2332,7 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap,
}
err = ceph_pagelist_encode_string(pagelist, path, pathlen);
if (err)
- goto out;
+ goto out_free;
spin_lock(&inode->i_lock);
cap->seq = 0; /* reset cap seq */
@@ -2376,8 +2376,9 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap,
unlock_kernel();
}
-out:
+out_free:
kfree(path);
+out_dput:
dput(dentry);
return err;
}
OpenPOWER on IntegriCloud