summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2009-10-20 02:35:50 +0000
committerDavid S. Miller <davem@davemloft.net>2009-10-22 21:54:19 -0700
commitdb519144243de6b17ff0c56c26f06059743110a7 (patch)
treef758c88e703bf2064454c45c439bb0428fb57db3
parentbc36b4285136bcc8dd43e91ffe34df6a52a0cfaf (diff)
downloadop-kernel-dev-db519144243de6b17ff0c56c26f06059743110a7.zip
op-kernel-dev-db519144243de6b17ff0c56c26f06059743110a7.tar.gz
ifb: should not use __dev_get_by_index() without locks
At this point (ri_tasklet()), RTNL or dev_base_lock are not held, we must use dev_get_by_index() instead of __dev_get_by_index() Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ifb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 801f088..030913f 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -98,12 +98,13 @@ static void ri_tasklet(unsigned long dev)
stats->tx_packets++;
stats->tx_bytes +=skb->len;
- skb->dev = __dev_get_by_index(&init_net, skb->iif);
+ skb->dev = dev_get_by_index(&init_net, skb->iif);
if (!skb->dev) {
dev_kfree_skb(skb);
stats->tx_dropped++;
break;
}
+ dev_put(skb->dev);
skb->iif = _dev->ifindex;
if (from & AT_EGRESS) {
OpenPOWER on IntegriCloud