diff options
author | Dave Chinner <dchinner@redhat.com> | 2013-09-02 10:32:00 +1000 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-09-10 12:57:09 -0500 |
commit | daf7b799a944d28a50caaa512011f5a0eb5a4076 (patch) | |
tree | e4a272ebf3b4b0247acbc4c1a61739cd0490a639 | |
parent | 638f44163d57f87d0905fbed7d54202beff916fc (diff) | |
download | op-kernel-dev-daf7b799a944d28a50caaa512011f5a0eb5a4076.zip op-kernel-dev-daf7b799a944d28a50caaa512011f5a0eb5a4076.tar.gz |
xfs: set remote symlink buffer type for recovery
The logging of a remote symlink block does not set the buffer type
being logged, and hence on recovery the type of buffer is not
recognised and hence CRCs are not calculated after replay. This
results in log recoery throwing:
XFS (vdc): Unknown buffer type 0
errors, and subsequent reads of the symlink failing CRC
verification. Found via fsstress + godown.
Reported by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r-- | fs/xfs/xfs_symlink.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c index 2f2a7c0..f622a97 100644 --- a/fs/xfs/xfs_symlink.c +++ b/fs/xfs/xfs_symlink.c @@ -41,6 +41,7 @@ #include "xfs_trans_space.h" #include "xfs_trace.h" #include "xfs_symlink.h" +#include "xfs_buf_item.h" /* ----- Kernel only functions below ----- */ STATIC int @@ -363,6 +364,7 @@ xfs_symlink( pathlen -= byte_cnt; offset += byte_cnt; + xfs_trans_buf_set_type(tp, bp, XFS_BLFT_SYMLINK_BUF); xfs_trans_log_buf(tp, bp, 0, (buf + byte_cnt - 1) - (char *)bp->b_addr); } |