summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSarang Radke <sarang.radke@qlogic.com>2010-03-10 04:03:04 -0600
committerJames Bottomley <James.Bottomley@suse.de>2010-03-27 15:08:08 -0400
commitd88a714bfefa7aed7b9cb6c3721707fcd056b472 (patch)
treeea791b7a50c10a035ec4819a4eb0b5977c107cc5
parent4ae0a6c15efcc37e94e3f30e3533bdec03c53126 (diff)
downloadop-kernel-dev-d88a714bfefa7aed7b9cb6c3721707fcd056b472.zip
op-kernel-dev-d88a714bfefa7aed7b9cb6c3721707fcd056b472.tar.gz
[SCSI] scsi_transport_fc: Make sure commands are completed when rport is offline
blk_end_request doesn't complete a bidi request successfully The unfinished request eventually triggers a panic in timeout handling routine fc_bsg_job_timeout as req->special is NULL Use blk_end_request_all to end the request unconditionally Signed-off-by: Lalit Chandivade <lalit.chandivade@qlogic.com> Acked-by: James Smart <james.smart@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r--drivers/scsi/scsi_transport_fc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 1d5b721..e37aeeb 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -3852,7 +3852,7 @@ fc_bsg_request_handler(struct request_queue *q, struct Scsi_Host *shost,
if (rport && (rport->port_state != FC_PORTSTATE_ONLINE)) {
req->errors = -ENXIO;
spin_unlock_irq(q->queue_lock);
- blk_end_request(req, -ENXIO, blk_rq_bytes(req));
+ blk_end_request_all(req, -ENXIO);
spin_lock_irq(q->queue_lock);
continue;
}
@@ -3862,7 +3862,7 @@ fc_bsg_request_handler(struct request_queue *q, struct Scsi_Host *shost,
ret = fc_req_to_bsgjob(shost, rport, req);
if (ret) {
req->errors = ret;
- blk_end_request(req, ret, blk_rq_bytes(req));
+ blk_end_request_all(req, ret);
spin_lock_irq(q->queue_lock);
continue;
}
OpenPOWER on IntegriCloud