summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2014-03-25 21:37:09 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2014-03-25 17:42:16 -0700
commitd6f2589ad561aa5fa39f347eca6942668b7560a1 (patch)
tree48708ad51abdeed29c5787350f0f2a378297754d
parent632b06aa2842b12c6d6a510ec080fb6ebdb38ea5 (diff)
downloadop-kernel-dev-d6f2589ad561aa5fa39f347eca6942668b7560a1.zip
op-kernel-dev-d6f2589ad561aa5fa39f347eca6942668b7560a1.tar.gz
fs: Avoid userspace mounting anon_inodefs filesystem
anon_inodefs filesystem is a kernel internal filesystem userspace shouldn't mess with. Remove registration of it so userspace cannot even try to mount it (which would fail anyway because the filesystem is MS_NOUSER). This fixes an oops triggered by trinity when it tried mounting anon_inodefs which overwrote anon_inode_inode pointer while other CPU has been in anon_inode_getfile() between ihold() and d_instantiate(). Thus effectively creating dentry pointing to an inode without holding a reference to it. Reported-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/anon_inodes.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 2408473..4b4543b 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -177,9 +177,6 @@ static int __init anon_inode_init(void)
{
int error;
- error = register_filesystem(&anon_inode_fs_type);
- if (error)
- goto err_exit;
anon_inode_mnt = kern_mount(&anon_inode_fs_type);
if (IS_ERR(anon_inode_mnt)) {
error = PTR_ERR(anon_inode_mnt);
OpenPOWER on IntegriCloud