diff options
author | Johannes Thumshirn <jthumshirn@suse.de> | 2015-07-08 17:16:49 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-09 00:04:16 -0700 |
commit | d5de1987853a7778bb048a9e52b3486eb9aceb17 (patch) | |
tree | f0f505b3976010928763d2c66b3a4e9f923d314b | |
parent | ace15bbb39d7cdfa1f376badbc7e0633eed7d899 (diff) | |
download | op-kernel-dev-d5de1987853a7778bb048a9e52b3486eb9aceb17.zip op-kernel-dev-d5de1987853a7778bb048a9e52b3486eb9aceb17.tar.gz |
macvtap: Destroy minor_idr on module_exit
Destroy minor_idr on module_exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez
<mcgrof@suse.com>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@
module_init(init);
@ defines_module_exit @
identifier exit;
@@
module_exit(exit);
@ declares_idr depends on defines_module_init && defines_module_exit @
identifier idr;
@@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
idr_destroy(&idr);
...
}
@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
+idr_destroy(&idr);
}
</SmPL>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/macvtap.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 6a64197f..b4b6191 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -1294,6 +1294,7 @@ static void macvtap_exit(void) class_unregister(macvtap_class); cdev_del(&macvtap_cdev); unregister_chrdev_region(macvtap_major, MACVTAP_NUM_DEVS); + idr_destroy(&minor_idr); } module_exit(macvtap_exit); |