summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephane Eranian <eranian@google.com>2010-06-16 20:59:01 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2010-06-17 08:57:31 -0300
commitcf103a14dd2ab23f847e998c8881ea4a5f8090bf (patch)
treeda365868978d800ae8ca424d4d278e531b051fd9
parentf9af3a4c1f59753bdd5a49e3a34263005f96972e (diff)
downloadop-kernel-dev-cf103a14dd2ab23f847e998c8881ea4a5f8090bf.zip
op-kernel-dev-cf103a14dd2ab23f847e998c8881ea4a5f8090bf.tar.gz
perf record: Avoid synthesizing mmap() for all processes in per-thread mode
A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007. Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP entries even though it was running in per-thread mode. There was a bogus check to select what mmaps to synthesize. We only need all processes in system-wide mode. Cc: David S. Miller <davem@davemloft.net> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> LKML-Reference: <4c192107.4f1ee30a.4316.fffff98e@mx.google.com> Signed-off-by: Stephane Eranian <eranian@google.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/builtin-record.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 39c7247..5efc3fc 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -714,7 +714,7 @@ static int __cmd_record(int argc, const char **argv)
if (perf_guest)
perf_session__process_machines(session, event__synthesize_guest_os);
- if (!system_wide && cpu_list)
+ if (!system_wide)
event__synthesize_thread(target_tid, process_synthesized_event,
session);
else
OpenPOWER on IntegriCloud