diff options
| author | Vincent <vincent.stehle@laposte.net> | 2017-01-30 15:06:43 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-31 13:07:40 -0500 |
| commit | c73e44269369e936165f0f9b61f1f09a11dae01c (patch) | |
| tree | e2188e900ba06302f8ed2746cb07edd3efbc5c35 | |
| parent | 040587af31228d82c52267f717c9fcdb65f36335 (diff) | |
| download | op-kernel-dev-c73e44269369e936165f0f9b61f1f09a11dae01c.zip op-kernel-dev-c73e44269369e936165f0f9b61f1f09a11dae01c.tar.gz | |
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings:
drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch]
drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle]
Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support")
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Sunil Goutham <sgoutham@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/cavium/thunder/thunder_xcv.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c index 67befed..578c7f8 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c @@ -116,8 +116,7 @@ void xcv_setup_link(bool link_up, int link_speed) int speed = 2; if (!xcv) { - dev_err(&xcv->pdev->dev, - "XCV init not done, probe may have failed\n"); + pr_err("XCV init not done, probe may have failed\n"); return; } |
