summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@linux-foundation.org>2007-04-25 22:07:58 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-25 22:30:02 -0700
commitc2886d6259b8faac4c05ffd9c3c401ac84478de0 (patch)
tree88bcce1789b029334f9a19db8e78f79d5f8fc808
parent2111f8b9e58fd04b87b8b07d66485f255a57b0bb (diff)
downloadop-kernel-dev-c2886d6259b8faac4c05ffd9c3c401ac84478de0.zip
op-kernel-dev-c2886d6259b8faac4c05ffd9c3c401ac84478de0.tar.gz
[BRIDGE]: if no STP then forward all BPDUs
If a bridge is not running STP, then it has no way to detect a cycle in the network. But if it is not running STP and some other machine or device is running STP, then if STP BPDU's get forwarded to it can detect the cycle. This is how the old 2.4 and early 2.6 code worked. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/bridge/br_input.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index 5662567..420bbb9 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -136,8 +136,14 @@ struct sk_buff *br_handle_frame(struct net_bridge_port *p, struct sk_buff *skb)
if (skb->protocol == htons(ETH_P_PAUSE))
goto drop;
- return (NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, skb->dev,
- NULL, br_handle_local_finish) == 0) ? skb : NULL;
+ /* Process STP BPDU's through normal netif_receive_skb() path */
+ if (p->br->stp_enabled != BR_NO_STP) {
+ if (NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, skb->dev,
+ NULL, br_handle_local_finish))
+ return NULL;
+ else
+ return skb;
+ }
}
switch (p->state) {
OpenPOWER on IntegriCloud