diff options
| author | Daniel Thompson <daniel.thompson@linaro.org> | 2015-03-02 14:13:36 +0000 |
|---|---|---|
| committer | Jason Wessel <jason.wessel@windriver.com> | 2017-12-06 16:12:43 -0600 |
| commit | c07d35338081d107e57cf37572d8cc931a8e32e2 (patch) | |
| tree | 80a6e4faf56936d6524340593ed7d33fd4d4bdb5 | |
| parent | bebc6082da0a9f5d47a1ea2edc099bf671058bd4 (diff) | |
| download | op-kernel-dev-c07d35338081d107e57cf37572d8cc931a8e32e2.zip op-kernel-dev-c07d35338081d107e57cf37572d8cc931a8e32e2.tar.gz | |
kdb: Fix handling of kallsyms_symbol_next() return value
kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.
This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
| -rw-r--r-- | kernel/debug/kdb/kdb_io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index e74be38..ed5d349 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -350,7 +350,7 @@ poll_again: } kdb_printf("\n"); for (i = 0; i < count; i++) { - if (kallsyms_symbol_next(p_tmp, i) < 0) + if (WARN_ON(!kallsyms_symbol_next(p_tmp, i))) break; kdb_printf("%s ", p_tmp); *(p_tmp + len) = '\0'; |
