summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSean Hefty <sean.hefty@intel.com>2007-06-05 09:57:31 -0700
committerRoland Dreier <rolandd@cisco.com>2007-06-07 23:24:38 -0700
commitbf2944bd56c7a48cc3962a860dbc4ceee6b1ace8 (patch)
treeb6255f3830965ddc615a0b872bd3c4bbfa1bf492
parent57f01b53398baebd809e7efd49fc10c10174b46d (diff)
downloadop-kernel-dev-bf2944bd56c7a48cc3962a860dbc4ceee6b1ace8.zip
op-kernel-dev-bf2944bd56c7a48cc3962a860dbc4ceee6b1ace8.tar.gz
RDMA/cma: Fix initialization of next_port
next_port should be between sysctl_local_port_range[0] and [1]. However, it is initially set to a random value with get_random_bytes(). If the value is negative when treated as a signed integer, next_port can end up outside the expected range because of the result of the % operator being negative. Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r--drivers/infiniband/core/cma.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 2eb52b7..32a0e66 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2773,8 +2773,8 @@ static int cma_init(void)
int ret;
get_random_bytes(&next_port, sizeof next_port);
- next_port = (next_port % (sysctl_local_port_range[1] -
- sysctl_local_port_range[0])) +
+ next_port = ((unsigned int) next_port %
+ (sysctl_local_port_range[1] - sysctl_local_port_range[0])) +
sysctl_local_port_range[0];
cma_wq = create_singlethread_workqueue("rdma_cm");
if (!cma_wq)
OpenPOWER on IntegriCloud