summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-12-04 16:19:49 +0300
committerKalle Valo <kvalo@codeaurora.org>2015-12-11 13:22:57 +0200
commitbd9a212bab3db65baff094fe811ef1b593faca2a (patch)
treee0da0eecaec12d056fc204bd7b34b26f62138230
parent9e4aee43dc2211a976f8aa7df5cf823d7a4ae640 (diff)
downloadop-kernel-dev-bd9a212bab3db65baff094fe811ef1b593faca2a.zip
op-kernel-dev-bd9a212bab3db65baff094fe811ef1b593faca2a.tar.gz
prism54: off by one BUG_ON() test
This code was supposed to trigger a BUG() if we truncate the output but it's off by one so it allows one character to be truncated. Really drivers shouldn't call BUG_ON() and especially for something minor like this so I've changed it to a WARN_ON(). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
-rw-r--r--drivers/net/wireless/intersil/prism54/isl_ioctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/intersil/prism54/isl_ioctl.c b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
index ecbb054..48e8a97 100644
--- a/drivers/net/wireless/intersil/prism54/isl_ioctl.c
+++ b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
@@ -2036,7 +2036,7 @@ format_event(islpci_private *priv, char *dest, const char *str,
mlme->address,
(error ? (mlme->code ? " : REJECTED " : " : ACCEPTED ")
: ""), mlme->code);
- BUG_ON(n > IW_CUSTOM_MAX);
+ WARN_ON(n >= IW_CUSTOM_MAX);
*length = n;
}
OpenPOWER on IntegriCloud