summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnthony Romano <anthony.romano@coreos.com>2016-06-24 14:48:43 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2016-06-24 17:23:52 -0700
commitb9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe (patch)
tree876ddeec4c6f173304dc30a16ecaadca6eca23b8
parenta7b50abc90afb2e3c27e1bd212643cc53eaf0b60 (diff)
downloadop-kernel-dev-b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe.zip
op-kernel-dev-b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe.tar.gz
tmpfs: don't undo fallocate past its last page
When fallocate is interrupted it will undo a range that extends one byte past its range of allocated pages. This can corrupt an in-use page by zeroing out its first byte. Instead, undo using the inclusive byte range. Fixes: 1635f6a74152f1d ("tmpfs: undo fallocation on failure") Link: http://lkml.kernel.org/r/1462713387-16724-1-git-send-email-anthony.romano@coreos.com Signed-off-by: Anthony Romano <anthony.romano@coreos.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Hugh Dickins <hughd@google.com> Cc: Brandon Philips <brandon@ifup.co> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/shmem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/shmem.c b/mm/shmem.c
index a361449..24463b6 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2227,7 +2227,7 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset,
/* Remove the !PageUptodate pages we added */
shmem_undo_range(inode,
(loff_t)start << PAGE_SHIFT,
- (loff_t)index << PAGE_SHIFT, true);
+ ((loff_t)index << PAGE_SHIFT) - 1, true);
goto undone;
}
OpenPOWER on IntegriCloud