diff options
| author | Philip J Kelleher <pjk1939@linux.vnet.ibm.com> | 2013-06-18 14:49:48 -0500 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2013-06-19 13:52:10 +0200 |
| commit | b8b225da139f5770d7689b189fd5debc58f4b35d (patch) | |
| tree | a34347978dc3ba97d1d3582f5fe7a90240e40a30 | |
| parent | 3eb8dcafb5a73041e2f3b4a39c057a58e4354d83 (diff) | |
| download | op-kernel-dev-b8b225da139f5770d7689b189fd5debc58f4b35d.zip op-kernel-dev-b8b225da139f5770d7689b189fd5debc58f4b35d.tar.gz | |
rsxx: Adding EEH check inside cregs timeout.
Unfortunaly, our CPU register path does not do any kind of
EEH error checking. So to fix this issue, an ioread32 was
added to the CPU register timeout code. This way, the
driver can check to see if the timeout was caused by an EEH
error or not. This is a dummy read.
Signed-off-by: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/block/rsxx/cregs.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/block/rsxx/cregs.c b/drivers/block/rsxx/cregs.c index 4914464..926dce9 100644 --- a/drivers/block/rsxx/cregs.c +++ b/drivers/block/rsxx/cregs.c @@ -431,6 +431,15 @@ static int __issue_creg_rw(struct rsxx_cardinfo *card, *hw_stat = completion.creg_status; if (completion.st) { + /* + * This read is needed to verify that there has not been any + * extreme errors that might have occurred, i.e. EEH. The + * function iowrite32 will not detect EEH errors, so it is + * necessary that we recover if such an error is the reason + * for the timeout. This is a dummy read. + */ + ioread32(card->regmap + SCRATCH); + dev_warn(CARD_TO_DEV(card), "creg command failed(%d x%08x)\n", completion.st, addr); |
