diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2016-12-22 13:05:04 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2017-01-02 10:19:45 -0800 |
| commit | af3d387f49e5ea5b4d11e315e0140aac6dd176b8 (patch) | |
| tree | 7445d402b43e188269c8d295a4ed2b34df3d6367 | |
| parent | 309c675e62d140d46806ca3e6b29f4549076d0d6 (diff) | |
| download | op-kernel-dev-af3d387f49e5ea5b4d11e315e0140aac6dd176b8.zip op-kernel-dev-af3d387f49e5ea5b4d11e315e0140aac6dd176b8.tar.gz | |
hwmon: (sht15) use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.
The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/sht15.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index a2fdbb7..f16687c 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -769,7 +769,7 @@ static ssize_t sht15_show_humidity(struct device *dev, return ret ? ret : sprintf(buf, "%d\n", sht15_calc_humid(data)); } -static ssize_t show_name(struct device *dev, +static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -787,7 +787,7 @@ static SENSOR_DEVICE_ATTR(humidity1_fault, S_IRUGO, sht15_show_status, NULL, SHT15_STATUS_LOW_BATTERY); static SENSOR_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR, sht15_show_status, sht15_store_heater, SHT15_STATUS_HEATER); -static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); +static DEVICE_ATTR_RO(name); static struct attribute *sht15_attrs[] = { &sensor_dev_attr_temp1_input.dev_attr.attr, &sensor_dev_attr_humidity1_input.dev_attr.attr, |
