diff options
| author | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2012-03-07 18:56:29 +0200 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2012-03-09 09:39:31 +0200 |
| commit | add8287e3fa2160229117c9e1b7c9ca8cb661423 (patch) | |
| tree | a26e58b7ca0b1cdd6b0ac23926e8adc958ef562b | |
| parent | a29852be492d61001d86c6ebf5fff9b93d7b4be9 (diff) | |
| download | op-kernel-dev-add8287e3fa2160229117c9e1b7c9ca8cb661423.zip op-kernel-dev-add8287e3fa2160229117c9e1b7c9ca8cb661423.tar.gz | |
UBI: fix documentation and improve readability
The "max" parameter of 'find_wl_entry()' was documented incorrectly and
it actually means the maximum possible difference from the smallest erase
counter. Rename it to "diff" instead, and amend the documentation.
Reported-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
| -rw-r--r-- | drivers/mtd/ubi/wl.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c index 0696e36..8616f52 100644 --- a/drivers/mtd/ubi/wl.c +++ b/drivers/mtd/ubi/wl.c @@ -350,18 +350,19 @@ static void prot_queue_add(struct ubi_device *ubi, struct ubi_wl_entry *e) /** * find_wl_entry - find wear-leveling entry closest to certain erase counter. * @root: the RB-tree where to look for - * @max: highest possible erase counter + * @diff: maximum possible difference from the smallest erase counter * * This function looks for a wear leveling entry with erase counter closest to - * @max and less than @max. + * min + @diff, where min is the smallest erase counter. */ -static struct ubi_wl_entry *find_wl_entry(struct rb_root *root, int max) +static struct ubi_wl_entry *find_wl_entry(struct rb_root *root, int diff) { struct rb_node *p; struct ubi_wl_entry *e; + int max; e = rb_entry(rb_first(root), struct ubi_wl_entry, u.rb); - max += e->ec; + max = e->ec + diff; p = root->rb_node; while (p) { |
