summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-05-26 09:43:34 +0300
committerArtem Bityutskiy <dedekind1@gmail.com>2011-07-04 10:54:26 +0300
commita29fa9dfa4d5d1b962825c79f19d9b6f3f15843b (patch)
treebd7aa3733a869c69038b4474229fbc9ada002cbf
parent1b51e98365e42c27eb2664f8353bc62ab8c55c85 (diff)
downloadop-kernel-dev-a29fa9dfa4d5d1b962825c79f19d9b6f3f15843b.zip
op-kernel-dev-a29fa9dfa4d5d1b962825c79f19d9b6f3f15843b.tar.gz
UBIFS: minor cleanup: use S_ISREG helper
Instead of using long "(inode->i_mode & S_IFMT) != S_IFREG" expression, use shorted "!S_ISREG(inode->i_mode)". Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
-rw-r--r--fs/ubifs/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index de82c5d..2850385 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -85,7 +85,7 @@ static int validate_inode(struct ubifs_info *c, const struct inode *inode)
if (ui->data_len < 0 || ui->data_len > UBIFS_MAX_INO_DATA)
return 4;
- if (ui->xattr && (inode->i_mode & S_IFMT) != S_IFREG)
+ if (ui->xattr && !S_ISREG(inode->i_mode))
return 5;
if (!ubifs_compr_present(ui->compr_type)) {
OpenPOWER on IntegriCloud