summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2011-03-24 22:51:14 -0400
committerJ. Bruce Fields <bfields@redhat.com>2011-03-24 23:11:27 -0400
commit954032d2527f2fce7355ba70709b5e143d6b686f (patch)
treee602da8c751a208c72ca7beb7edbdd10cf955884
parent4be34b9d69c97211ff4eb00d79078f3c1593804d (diff)
downloadop-kernel-dev-954032d2527f2fce7355ba70709b5e143d6b686f.zip
op-kernel-dev-954032d2527f2fce7355ba70709b5e143d6b686f.tar.gz
nfsd: fix auth_domain reference leak on nlm operations
This was noticed by users who performed more than 2^32 lock operations and hence made this counter overflow (eventually leading to use-after-free's). Setting rq_client to NULL here means that it won't later get auth_domain_put() when it should be. Appears to have been introduced in 2.5.42 by "[PATCH] kNFSd: Move auth domain lookup into svcauth" which moved most of the rq_client handling to common svcauth code, but left behind this one line. Cc: Neil Brown <neilb@suse.de> Cc: stable@kernel.org Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/lockd.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfsd/lockd.c b/fs/nfsd/lockd.c
index 0c6d816..7c831a2 100644
--- a/fs/nfsd/lockd.c
+++ b/fs/nfsd/lockd.c
@@ -38,7 +38,6 @@ nlm_fopen(struct svc_rqst *rqstp, struct nfs_fh *f, struct file **filp)
exp_readlock();
nfserr = nfsd_open(rqstp, &fh, S_IFREG, NFSD_MAY_LOCK, filp);
fh_put(&fh);
- rqstp->rq_client = NULL;
exp_readunlock();
/* We return nlm error codes as nlm doesn't know
* about nfsd, but nfsd does know about nlm..
OpenPOWER on IntegriCloud