summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMing Lei <ming.lei@redhat.com>2017-12-18 20:22:08 +0800
committerJens Axboe <axboe@kernel.dk>2018-01-06 09:18:00 -0700
commit8f50e358153dd68182c714626be4a90b64179cf4 (patch)
tree271cef801d2e2757eed59270948993b65ae10d06
parent3c892a098b0bfa3e571f1f0d2a7e72fbaeea691a (diff)
downloadop-kernel-dev-8f50e358153dd68182c714626be4a90b64179cf4.zip
op-kernel-dev-8f50e358153dd68182c714626be4a90b64179cf4.tar.gz
dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE
For BIO based DM, some targets aren't ready for dealing with bigger incoming bio than 1Mbyte, such as crypt target. Cc: Mike Snitzer <snitzer@redhat.com> Cc:dm-devel@redhat.com Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/md/dm.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index de17b71..7475739 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -920,7 +920,15 @@ int dm_set_target_max_io_len(struct dm_target *ti, sector_t len)
return -EINVAL;
}
- ti->max_io_len = (uint32_t) len;
+ /*
+ * BIO based queue uses its own splitting. When multipage bvecs
+ * is switched on, size of the incoming bio may be too big to
+ * be handled in some targets, such as crypt.
+ *
+ * When these targets are ready for the big bio, we can remove
+ * the limit.
+ */
+ ti->max_io_len = min_t(uint32_t, len, BIO_MAX_PAGES * PAGE_SIZE);
return 0;
}
OpenPOWER on IntegriCloud