summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobin C. Harding <me@tobin.cc>2017-04-10 13:15:40 +1000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-04-11 16:03:36 +0200
commit881f76b976e8e1ce8bb0498d0a85f3a43a6397dd (patch)
tree6600581dacf95519b49ae4446c47e3171125f360
parent5141e9c6346892d9705558ccf27489806c2bdddf (diff)
downloadop-kernel-dev-881f76b976e8e1ce8bb0498d0a85f3a43a6397dd.zip
op-kernel-dev-881f76b976e8e1ce8bb0498d0a85f3a43a6397dd.tar.gz
staging: ks7010: change length type to unsigned
Length undergoes type conversion when passed (indirectly) as an argument for parameter of type 'unsigned int'. If length is negative this is a bug (the value after conversion is large). Declare 'length' to be an unsigned type instead of a signed type. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/ks7010/ks7010_sdio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 3403edd..b93c9a4 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -712,7 +712,7 @@ static int ks7010_upload_firmware(struct ks_sdio_card *card)
unsigned char *rom_buf;
unsigned char rw_data = 0;
int ret;
- int length;
+ unsigned int length;
const struct firmware *fw_entry = NULL;
/* buffer allocate */
OpenPOWER on IntegriCloud