summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTodd Poynor <tpoynor@mvista.com>2005-11-05 03:21:15 +0000
committerThomas Gleixner <tglx@mtd.linutronix.de>2005-11-07 02:24:31 +0100
commit868801e561d5d6df40a66197e2f803a109c19e7a (patch)
treef13cc0daeda783d3710161a8a641573c76bea600
parent49196f3332e661ccc221734c3103115d8cd4ee49 (diff)
downloadop-kernel-dev-868801e561d5d6df40a66197e2f803a109c19e7a.zip
op-kernel-dev-868801e561d5d6df40a66197e2f803a109c19e7a.tar.gz
[MTD] NAND: nand_write_ecc memory and OOB corruption
Nathan Roberts noticed the nand_write_ecc index into oobbuf goes out of bounds when crossing an erase block boundary, causing incorrect OOB data to be written and corrupting memory. Reset the index to zero after re-preparing oobbuf for a new erase block. Signed-off-by: Todd Poynor <tpoynor@mvista.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--drivers/mtd/nand/nand_base.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index c7b1ce3..c18ea76 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -1722,6 +1722,7 @@ static int nand_write_ecc (struct mtd_info *mtd, loff_t to, size_t len,
startpage = page;
oobbuf = nand_prepare_oobbuf (mtd, eccbuf, oobsel,
autoplace, numpages);
+ oob = 0;
/* Check, if we cross a chip boundary */
if (!page) {
chipnr++;
OpenPOWER on IntegriCloud