summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRahul Ruikar <rahul.ruikar@gmail.com>2010-10-07 09:40:45 +0530
committerGreg Kroah-Hartman <gregkh@suse.de>2010-10-22 10:22:06 -0700
commit75d87cdf3cefd2744fabd3f2a558c49cdf36238b (patch)
treea6ab2768b95d9fac5695edcbde1418c661d6b3ee
parent7b3a766c7b9bce07875098cb68642df2b8f0b152 (diff)
downloadop-kernel-dev-75d87cdf3cefd2744fabd3f2a558c49cdf36238b.zip
op-kernel-dev-75d87cdf3cefd2744fabd3f2a558c49cdf36238b.tar.gz
usb: gadget: dummy_hcd: Fix error path
In function dummy_udc_probe() call put_device() when device_register() fails. also usb_get_hcd() put before device_register() after review comment from Alan Stern. Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/gadget/dummy_hcd.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 7bb9d78..1d2a2ab 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
struct dummy *dum = the_controller;
int rc;
+ usb_get_hcd(dummy_to_hcd(dum));
+
dum->gadget.name = gadget_name;
dum->gadget.ops = &dummy_ops;
dum->gadget.is_dualspeed = 1;
@@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
dum->gadget.dev.parent = &pdev->dev;
dum->gadget.dev.release = dummy_gadget_release;
rc = device_register (&dum->gadget.dev);
- if (rc < 0)
+ if (rc < 0) {
+ put_device(&dum->gadget.dev);
return rc;
-
- usb_get_hcd (dummy_to_hcd (dum));
+ }
platform_set_drvdata (pdev, dum);
rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
OpenPOWER on IntegriCloud