summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2010-02-05 16:16:50 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2010-02-06 13:00:37 -0800
commit6f5a55f1a6c5abee15a0e878e5c74d9f1569b8b0 (patch)
tree2b5304a71a3b2ef2f0665e4e2d9262c6c6918848
parent9d9c3a51e7b20dcd63b8cc534035af99a41d03e4 (diff)
downloadop-kernel-dev-6f5a55f1a6c5abee15a0e878e5c74d9f1569b8b0.zip
op-kernel-dev-6f5a55f1a6c5abee15a0e878e5c74d9f1569b8b0.tar.gz
Fix potential crash with sys_move_pages
We incorrectly depended on the 'node_state/node_isset()' functions testing the node range, rather than checking it explicitly. That's not reliable, even if it might often happen to work. So do the proper explicit test. Reported-by: Marcus Meissner <meissner@suse.de> Acked-and-tested-by: Brice Goglin <Brice.Goglin@inria.fr> Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/migrate.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/mm/migrate.c b/mm/migrate.c
index efddbf0..9a0db5b 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -912,6 +912,9 @@ static int do_pages_move(struct mm_struct *mm, struct task_struct *task,
goto out_pm;
err = -ENODEV;
+ if (node < 0 || node >= MAX_NUMNODES)
+ goto out_pm;
+
if (!node_state(node, N_HIGH_MEMORY))
goto out_pm;
OpenPOWER on IntegriCloud